This repository was archived by the owner on Oct 22, 2021. It is now read-only.
quick fix for #43 #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Jan 21, 2018
| path = '' | ||
| } | ||
|
|
||
| return pathsArray.map(function(f) { |
Owner
There was a problem hiding this comment.
This change is bothering me and should not be needed.
Take a look at the paths function here.
Your custom search is leading to the path not being an array nor a string there. However, the data returned by the custom searched should be parsed here.
It the output is how you said:
somepath
somepath2
The search will output an array and this should not be needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.